remove reliance on old trait solver bug #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋 we discovered this project during a crater run with the next-generation trait solver in rust-lang/rust#133502.
The generic parameter
QofQueryHandleris underconstrained here as it could be any typeTwith<T as Query>::Refs<'a>being equal to<Q as Query>::Refs<'a>. It isn't actually necessary forTto beQitself, e.g. it could also be a type which delegates toQsQueryimpl. The current type system implementation unnecessarily constrainedTto be equal toQ. This will no longer be the case with the new trait solver.See rust-lang/trait-system-refactor-initiative#168 or the related breakage in
bevyfor more details .I am sorry for the inconvenience and am available in case there are any questions.