Syntax bugs fixed, Fixing issue #69 #72
Conversation
|
Important Required App Permission UpdateNoise Reduction ImprovementsThis update requests write permissions for Commit Statuses in order to send updates directly to your PRs without adding comments that spam notifications. Visit our changelog to learn more. Click here to accept the updated permissions To accept the updated permissions, sufficient privileges are required |
vijay-varadarajan
changed the title
|
/korbit-generate-pr-description |
|
@vijay-varadarajan I am looking at your pull request. The description will be updated shortly. In the meantime, please do not edit the description until I have finished writing mine. |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Debug prints in production code ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| quantstats_lumi/utils.py | ✅ |
| quantstats_lumi/_plotting/wrappers.py | ✅ |
| quantstats_lumi/_plotting/core.py | ✅ |
| quantstats_lumi/reports.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
1 participant
Fixing issue #69.
benchmark.to_frame()to_pd.DataFrame(benchmark)_match_datesfunction ("""match dates of returns and benchmark""") to support different dtypes ofreturnsandbenchmarkDescription by Korbit AI
What change is being made?
Add print statements to debug and trace execution paths in functions related to plotting and report generation, as well as ensure returns preparation flag is respected in the
monthly_returns_detailedviewfunction.Why are these changes being made?
The print statements will assist with debugging by providing on-the-fly execution path insights, which is crucial for diagnosing problems in complex data processing pipelines. The change in the
monthly_returns_detailedviewfunction ensures that returns are prepared conditionally based on a newly introduced flag, enhancing the flexibility and correctness of data processing.