almost finished schwab, testing #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Required App Permission UpdateNoise Reduction ImprovementsThis update requests write permissions for Commit Statuses in order to send updates directly to your PRs without adding comments that spam notifications. Visit our changelog to learn more. Click here to accept the updated permissions To accept the updated permissions, sufficient privileges are required |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Exposed Authentication Endpoint ▹ view | 🧠 Incorrect |
Files scanned
| File Path | Reviewed |
|---|---|
| setup.py | ✅ |
| lumibot/brokers/schwab.py | ✅ |
| lumibot/strategies/strategy.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+1645
to
+1653
| @app.route("/schwab-login") | ||
| def schwab_login(): | ||
| client_from_login_flow( | ||
| api_key = self.client.api_key, | ||
| app_secret = self.client.app_secret, | ||
| callback_url = redirect_uri, | ||
| token_path = token_path, | ||
| interactive = False | ||
| ) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Update the Schwab API integration documentation and add Flask-based cloud authentication flow for Schwab broker integration in the Lumibot trading library.
Why are these changes being made?
The documentation update reflects new support and guidelines for using Schwab's modern Trader API, specifically with Lumibot, detailing credential setup, OAuth login, and asset support. Enhancements in the code include improved environment detection for redirect URIs and a Flask-based web route for completing the OAuth login process in cloud environments, simplifying the setup for hosting platforms like Replit or Render. This update ensures users have accurate information and support for deploying strategies using Schwab's API with Lumibot effectively.