-
Notifications
You must be signed in to change notification settings - Fork 214
Alpaca multi leg options and tweaks #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GrizzlyEnglish
wants to merge
11
commits into
Lumiwealth:dev
Choose a base branch
from
GrizzlyEnglish:renglish/alpaca-order-options
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
687fc02
feat: Update orders to have options as well, with few tweaks
GrizzlyEnglish cef4c0f
fixup! feat: Update orders to have options as well, with few tweaks
GrizzlyEnglish 9627f4a
fixup! feat: Update orders to have options as well, with few tweaks
GrizzlyEnglish 6be86f3
fixup! feat: Update orders to have options as well, with few tweaks
GrizzlyEnglish b358ae2
merge up
GrizzlyEnglish cac5d00
fix: merge issue on types
GrizzlyEnglish 46ba483
fix: remove print
GrizzlyEnglish 3b7645e
Merge remote-tracking branch 'upstream/dev' into renglish/alpaca-orde…
GrizzlyEnglish 53a1a72
fix: Fix merge issues
GrizzlyEnglish 4c93bcb
fix: Bar check
GrizzlyEnglish 0bc7be0
fix: Order type was wrong on the alpaca object
GrizzlyEnglish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sequential Order Submission
Tell me more
What is the issue?
Orders are submitted sequentially in a loop, which could be slow for large batches of orders.
Why this matters
Sequential order submission increases total execution time and could cause delays in high-frequency trading scenarios.
Suggested change ∙ Feature Preview
Implement concurrent order submission using asyncio:
💬 Chat with Korbit by mentioning @korbit-ai.