Create local lint.sh file #86
Conversation
|
@0xBEEFCAF3 I think our problem was some conflicts in our version tree from possibly having work before 0.23.0 |
|
|
||
| # Run clippy at top level for crates without feature-specific checks | ||
| echo "Running workspace lint..." | ||
| cargo +nightly clippy --all-targets --keep-going --all-features -- -D warnings |
There was a problem hiding this comment.
is it ok that I added +nightly here? not sure if that is something we always want to be the case for lints
There was a problem hiding this comment.
I believe we implictly use nightly for rust-payjoin so that should be fine.
There was a problem hiding this comment.
Note that this does assume that the runner is installed using rustup, which may not always be the case
We had a hard time getting the lint working locally with a standard cargo clippy command and as a result we should probably ensure that we all have a standardized way of linting the source in the repo.
|
I'm comfortable merging on armin's ack, but the commit hash changed. Ideally we run this from flake-configured rust version but for now I'm not completely opposed to the concept for this repo. |
|
Sorry! I had split the add lint file and clippy fixes just as I got the review |
3 participants
We had a hard time getting the lint working locally with a standard cargo clippy command and as a result we should probably ensure that we all have a standardized way of linting the source in the repo.