Depend on payjoin/{v1,v2} features #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payjoin-ffi depends on the v2 state machine and thus requires the payjoin/v2 feature. However, due to a bug where V1Context is pub(crate) in the payjoin/v2 feature configuration, payjoin/v1 also needs to be enabled until that upstream payjoin crate bug is fixed.
kirillzh
approved these changes
Mar 22, 2025
|
I found it odd that this wasn't working in my own environment, since payjoin/v2 ought to be a default payjoin feature. That said, being explicit does not hurt. |
arminsabouri
approved these changes
Mar 23, 2025
There was a problem hiding this comment.
tACK 8e80e21
Tested by generating linux bindings. The python tests are still failing but they are also failing in main.
AttributeError: module 'payjoin' has no attribute 'IsScriptOwned'
spacebear21
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
payjoin-ffi depends on the v2 state machine and thus requires the payjoin/v2 feature. However, due to a bug where V1Context is pub(crate) in the payjoin/v2 feature configuration, payjoin/v1 also needs to be enabled until that upstream payjoin crate bug is fixed.
the bug payjoin/rust-payjoin#599