-
Notifications
You must be signed in to change notification settings - Fork 14
Error bindings #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Error bindings #58
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6ba6322
Update Cargo.toml
spacebear21 2cb8795
Expose receiver error types
spacebear21 7842265
Fix renamed SenderBuilder constructor
spacebear21 c1d071b
Expose sender error types
spacebear21 4662b4a
Move uri.rs to uri/mod.rs
spacebear21 6764488
Expose uri error types
spacebear21 b38b18c
Add OhttpError mapping
spacebear21 e063224
Add IoError mapping
spacebear21 86e03f2
Add SerdeJsonError mapping
spacebear21 84436d3
Delete PayjoinError
spacebear21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
#[derive(Debug, PartialEq, Eq, thiserror::Error)] | ||
#[error("Error parsing the payjoin URI: {msg}")] | ||
#[cfg_attr(feature = "uniffi", derive(uniffi::Object))] | ||
pub struct PjParseError { | ||
msg: String, | ||
} | ||
|
||
impl From<String> for PjParseError { | ||
fn from(msg: String) -> Self { | ||
PjParseError { msg } | ||
} | ||
} | ||
|
||
#[derive(Debug, PartialEq, Eq, thiserror::Error)] | ||
#[error("URI doesn't support payjoin: {msg}")] | ||
#[cfg_attr(feature = "uniffi", derive(uniffi::Object))] | ||
pub struct PjNotSupported { | ||
msg: String, | ||
} | ||
|
||
impl From<String> for PjNotSupported { | ||
fn from(msg: String) -> Self { | ||
PjNotSupported { msg } | ||
} | ||
} | ||
|
||
#[derive(Debug, PartialEq, Eq, thiserror::Error)] | ||
#[error("Error parsing URL: {msg}")] | ||
#[cfg_attr(feature = "uniffi", derive(uniffi::Object))] | ||
pub struct UrlParseError { | ||
msg: String, | ||
} | ||
|
||
impl From<payjoin::ParseError> for UrlParseError { | ||
fn from(value: payjoin::ParseError) -> Self { | ||
UrlParseError { msg: format!("{:?}", value) } | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very smelly, address it in the audit. If we need this because we depend on bitcoin_uri errors in the public API, maybe we should reconsider those rather than making arbitrary string conversions part of the API.
Manual map_err seems a lot more appropriate in this circumstance.