Skip to content

Conversation

arminsabouri
Copy link
Contributor

Generated via ./scrtipts/generate_linux && ./scripts/generate_windows.

Unit and integration tests are passing ✔️

The diff in python/src/payjoin/payjoin_ffi.py seems to have cut alot of code making me think I have missed a step in the process. @BitcoinZavior any ideas what I could be missing?

Note: I am having some issues cross compiling for MacOS. Drafting for now. If someone has experience with this, help would be appeciated

error: failed to run custom build command for `secp256k1-sys v0.10.1`
...
  error occurred: Command LC_ALL="C" "cc" "-Os" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-mmacosx-version-min=11.0" "-I" "depend/secp256k1/" "-I" "depend/secp256k1/include" "-I" "depend/secp256k1/src" "-I" "wasm/wasm-sysroot" "-Wall" "-Wextra" "-DSECP256K1_API=" "-DENABLE_MODULE_ECDH=1" "-DENABLE_MODULE_SCHNORRSIG=1" "-DENABLE_MODULE_EXTRAKEYS=1" "-DENABLE_MODULE_ELLSWIFT=1" "-Dprintf(...)=" "-DECMULT_GEN_PREC_BITS=4" "-DECMULT_WINDOW_SIZE=15" "-DUSE_EXTERNAL_DEFAULT_CALLBACKS=1" "-DENABLE_MODULE_RECOVERY=1" "-o" "/home/hash160/dev/payjoin-ffi/target/aarch64-apple-darwin/release-smaller/build/secp256k1-sys-c3b649339ff391aa/out/4d6b2bbe68124288-lax_der_parsing.o" "-c" "depend/secp256k1/contrib/lax_der_parsing.c" with args cc did not execute successfully (status code exit status: 1).

Generated via `./scrtipts/generate_linux && ./scripts/generate_windows`.
@DanGould
Copy link
Contributor

DanGould commented Mar 19, 2025

Do generated binaries it even make sense to commit? I'm not even sure we want to commit generated source. If our tests show the binaries can be produced and tested against it usually makes for a cleaner git repo to only have source code.

@DanGould
Copy link
Contributor

That said, we still need to figure out MacOS

@arminsabouri
Copy link
Contributor Author

Do generated binaries it even make sense to commit? I'm not even sure we want to commit generated source. If our tests show the binaries can be produced and tested against it usually makes for a cleaner git repo to only have source code.

Ack lets remove the shared objects/dylibs from git and also the payjoin-ffi generated file. If we ever want to package this and ship it to a package-manger (pip) this can be easily done in CI.

@arminsabouri
Copy link
Contributor Author

Closing in favor of a440ce0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants