Move bitcoinlib dependency to requirments.txt #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BitcoinZavior what is this? |
|
It seems to me python-bitcoinlib is a dev dependency just for tests. We could make a |
`bitcoinlib` is installed implicitly as a dev dependency during env setup. This commit moved bitcoinlib to a dev-requirments file and pins the version to ^0.12.2.
arminsabouri
force-pushed
the
bitcoinlib-in-requirments
branch
from
e094a58 to
478fc26
Compare
|
@DanGould Moved to requirments-dev.txt |
DanGould
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found it odd this one dependency lived outside requirments.txt. I also pinned to a specific version. Any reason we want to explicitly install this one?