Use bitcoin-ffi types instead of our own bitcoin module. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import types from UDL and re-export as bitcoin_ffi to replace the bitcoin module.
BitcoinZavior
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes depend on bitcoin-ffi proc macrosThese changes import bitcoin-ffi using
uniffi::use_udl_object!, but proc macros would obsolete these lines.We still have an incomplete but effective
PsbtInputtype in ourbitcoinmodule, but everything else is pulled right from bitcoin_ffi 4cd8e644dbf4e001d71d5fffb232480fa5ff2246.