Tidepool merge

[ps2]

Features:

• Favorite foods insights
• Improved uploading to Tidepool. (Overrides, settings, automation status).
• (Development/testing) CGM Simulator supports Heartbeat fob

Fixes:

• Lockups relating to HK storage fixed
• Discrepancies in IOB between status page and insulin delivery history page fixed.
• IOB accounting and dose uploading during periods of suspension/neutral basal improved.

Algorithm Updates:

• Stateless algorithm
  • More reliable testing
  • Reusable package
  • Algorithm effects computations moved from stores into LoopAlgorithm package
  • Makes reuse of Loop Algorithm (Learn/Analysis apps) and data stores (Other AID systems) cleaner.
• Settings timelines
  • Algorithm uses settings history, so when you edit settings, you are not changing the past.
  • Overrides applied to history, which Loop also remembers now.
  • Overall leads to fewer surprises in sudden forecast and dosing changes.
• Mid-absorption ISF
  • When ISF changes (either via settings change, or override enact), the absorbed insulin will still use the previous ISF up until now, and the unabsorbed insulin will use the new ISF.
  • Example: If you dose for a meal, then decide to go on a walk, and set an override with a higher (more sensitive) ISF, then Loop will evaluate the remaining insulin using the new ISF; previously, Loop would use the ISF in effect at the time of dose starting.

Internal updates of note:

• Moving more methods over to async
  • This cleans up nested code, improves readability, and fewer lines of code.
  • Reduces errors like completion handlers not being called.

Other changes:

• Legacy today widget removed.

[marionbarker]

Work in progress testing:

Tested building this using a Mac (macOS 14.6) with Xcode 16.0 onto an iOS 15 phone. I have not completed doing my robustness tests but nothing to complain about yet.

Issue 1:

Found the first issue - reporting that here:

• Browser Build failed - here is the Action Log

Expected fix for Issue 1:

I did a quick test to update .github/workflows/build_loop.yml to use Xcode 16.1 instead of Xcode 15.4. But failed to update the Fastlane version so I got the Found more than 1 matching build: problem that we fixed earlier by updating Fastlane.

The build part was successful but the action failed because it didn't upload to TestFlight: Action Log

I will prepare a PR to LoopKit/LoopWorkspace tidepool-merge to update the build process to match main (refer to PR #164) as well as to update the Xcode version and update Fastlane. I'll make sure other build actions fixes are pulled in if necessary. In other words, I'll make sure it works before I create the PR.

Expiration Date Missing

The TestFlight build did upload (typical of this Fastlane version), and installed on an iOS 18.1 phone. As expected, the expiration date is not available (the update for this will be part of the planned PR).

[marionbarker]

Keep a list of Issues identified along with current status. Most of the discussion is on zulipchat under development: tidepool-merge

Item	Label	Status	Description
1	Browser Build	partially fixed see PR LoopKit/Loop#2252	Builds but TestFlight expiration date not included a new PR was prepared to make it easier to get the required Loop change to fix the TestFlight expiration
2	Loop Report Format	Loop PR 2272	Some sections start with Optional(## name instead of ## name The proposed PR fixes this with a forced unwrap
3	Loop upload to Nightscout incomplete	No solution found yet, needs to be fixed	Loop pill and forecast not uploaded with every cycle For example, these do not update NS * An automatic temp basal change is made * No change to dosing posture is made in the current Loop cycle * A manual temp basal is cancelled by the user These action do update Loop pill and forecast: automatic bolus, manual bolus, carb entry
4	Manual Temp Basal display	not planned	For iOS 15, iPhone 7+, had to turn phone to landscape to see duration picker For iOS 16.7.10, iPhone 8, normal display in portrait For iOS 18.1, SE phone, normal display in portrait
5	TidepoolService	fixed	External insulin logged on loop phone was added to Tidepool but was not removed when it is deleted from Loop phone fixed with TidepoolService commit 2cd32ca
6	Time Change Main Screen Indicator	merged into OmniKit main branch same as 3.4.4	I just noticed that the Eros pod I'm testing is showing time-change message on the Pod screen but no clock icon on main screen. Will repeat the test in a controlled manner. - MDT pump shows a clock icon on main screen. - DASH pod shows the clock icon on main screen - Eros does not show clock icon on main screen with Loop 3.4.4 or tidepool-merge updated in OmniKit main
7	Tidepool & MDT Basal Totals	N/A	See zulipchat link for details. Tests with Eros pods had no issues. One particular pump (MDT 523) gave discrepancies in insulin record (pump, AH, Tidepool, NS) for both tidepool-merge and Loop 3.4.4 builds. Rerunning tests with a different pump: MDT 515 resolved the discrepancy. I am assuming this was a hardware problem with the particular device.
8	Tests	One PR proposed, not complete Loop PR 2311	Realized I had not run Tests for tidepool-merge. Did that on 2025-03-22 and they failed. More evaluation is required.
9	ICE display, predicted glucose change not shown	N/A	See comment in this PR
10	Presets Insulin Needs seems inverted	Must be fixed	See discussion in zulipchat: #development > tidepool-merge @ 💬

[marionbarker]

Topic

I evaluated putting the requested feature of extended history for ICE display into the tidepool-merge branch (see Loop Issue 2159 and Loop PR 2182.

While doing this work, I found a bug in tidepool-merge. I will add this information as row 9 on the summary comment that keeps track of bugs and their resolution.

Status

The good news is, the modifications to tidepool-merge are straightforward and increasing the ICE history to one week is suggested (this will be a separate PR)

• With Loop main/dev, adding in a week of history really slowed down the app significantly compared to 2 days
• With tidepool-merge branch, including a week of history did not slow down the app

The bad news is the predicted part of the ICE display is not included in tidepool-merge (with commit noted below)

• I will see if I can fix this and post a PR to tidepool-merge to restore the predicted part of the display
• If someone sees the fix - please let me know

First graphic shows portrait and landscape ICE charts on an iPhone 8 running LoopWorkspace dev, commit 3d48a5c.

Second graphic shows portrait and landscape ICE charts on the same iPhone 8 running LoopWorkspace tidepool-merge, commit 17aa656.

[marionbarker]

Adding to prior comment. The predicted carbs are displayed but only starting one hour in the future.

This is a new screenshot using tidepool-merge after I added more carbs.

[iDustbin]

Browser Build isnt working on my Site, May you please fix it ?

[marionbarker]

@iDustbin Please ask for help in the appropriate channel on zulipchat or facebook.
I suggest #Build Issues > Loop 3.6.0

[marionbarker]

I just ran the tests for tidepool-merge and they fail to build.
I'm adding that to the table of items to fix in this comment:

• Tidepool merge #213 (comment)

Edited because I had already added that to the table.

[sarusso]

I did some work on the tests. PR LoopKit/Loop#2311 fixes an issue in the build phase, due to a missing fetchData() mock in the MockManualEntryDoseViewModelDelegate class.

After this, tests were building and passing on iOS 17.2, but not on 18.2. To make them pass on iOS 18.2, I had to change some assertions to match a different regional locale formatting. You can see what I changed here: sarusso/Loop@c9e8546, but I have not created a PR because I am not sure about what is going on here.