Fix several compilation/runtime errors #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: using gcc version 11.4.0
This caused a compilation error. Note: using gcc version 11.4.0
In C++, declaring a return value but not returning anything is unspecified behavior. Several functions/methods in this library are doing this, and in my case, it's causing a nasty SEGV to occur in unrelated Eigen code (probably because the program counter is falling of the end of the function and executing the unrelated Eigen code that happens to be below!). This is bad, so let's actually return (unused) values from these functions. Note: using gcc version 11.4.0
Currently, the project's CMakeLists.txt specified C++11, which is causing a PCL compilation error. Using C++14 instead causes a SEGV due to Eigen alignment issues (see https://eigen.tuxfamily.org/dox/group__DenseMatrixManipulation__Alignement.html). Upgrading to C++17 fixes these and allows the library to compile and run without segfaulting. Note: using gcc version 11.4.0
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.