Layout parser Custom Variables from LiveSplit layouts #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the livesplit-core layout parser to support LiveSplit layout files with custom variable definitions in Splits, Subsplits, and Text components. Key changes include adding tests for custom variables in layout files, updating layout file examples to include custom variable scenarios, and modifying the parser logic in both Text and Splits modules to properly handle "CustomVariable" types.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/layout_parsing.rs | New tests added for custom variable splits and subsplits |
| tests/layout_files/*.lsl & *.ls1l | Added layout examples with custom variable configurations |
| src/layout/parser/text.rs | Updated parsing to support custom variables in Text components |
| src/layout/parser/splits.rs | Modified column type parsing to support custom variable columns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A companion PR to LiveSplit/LiveSplit.Splits#27 and LiveSplit/LiveSplit.Subsplits#21, allowing
livesplit-core's layout parser to import.lslLiveSplit layout files containing Custom Variables in Splits, Subsplits, and Text components.