2.0.0-rc6.1 #1975
Merged
2.0.0-rc6.1 #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Android Add a null check for _customScaleListener in DisposeController in src/_Shared.Native/Platforms/Android/PointerController.cs to prevent crashes when navigating away without touching the chart. Only dispose _customScaleListener if it is not null.
…stener Fixes #1971 - Android Fix: Add a null check for _customScaleListener in DisposeController to prevent crash
Update Windows App SDK version to fix AOT issues
Generators works better from nuget (at least on Mac), and lets reference the source code in this repo instead of NuGet packages.
There was a problem hiding this comment.
Pull Request Overview
This pull request contains hotfixes for the 2.0.0-rc6.1 release, primarily focusing on dependency updates and sample refactoring.
- Updated Microsoft.WindowsAppSDK package versions to 1.7.250606001 across WinUI projects
- Fixed a potential null reference issue in Android pointer controller disposal
- Refactored chart sections samples to use data binding instead of hardcoded values
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| LiveChartsCore.SkiaSharpView.WinUI.csproj | Updated WindowsAppSDK and SDK.BuildTools package versions |
| PointerController.cs | Added null-conditional operator for safe disposal |
| WinUISample.csproj | Updated WindowsAppSDK package version |
| Various View.xaml files | Changed hardcoded section coordinates to data binding |
| ViewModel.cs files | Added properties for section coordinates or removed unused imports |
| template.md | Fixed broken link reference |
| Directory.Build.props | Updated version and build configuration flags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some hot fixes to
rc-6