Introduced SerializerBuilder and LanguageDeserializerBuilder #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results3 017 tests 3 010 ✅ 3s ⏱️ Results for commit 1ca8ab6. ♻️ This comment has been updated with latest results. |
enikao
changed the title
enikao
changed the title
dslmeinte
reviewed
Apr 22, 2025
| @@ -123,6 +123,9 @@ DynamicLanguage[] DeserializeExternalLanguage(LionWebVersions lionWebVersion, st | |||
| SerializationChunk serializationChunk = | |||
| JsonUtils.ReadJsonFromString<SerializationChunk>( | |||
| File.ReadAllText($"chunks/externalDefs/{lionWebVersion.VersionString}/{name}.json")); | |||
| return new LanguageDeserializer(lionWebVersion, compressedIdConfig: new(KeepOriginal: true)) | |||
| return new LanguageDeserializerBuilder() | |||
There was a problem hiding this comment.
What's the advantage of using the Builder Pattern over using a configuration object (with reasonable effective defaults)?
There was a problem hiding this comment.
That's a question for @JojoEffect -- seems to be more C#-ish.
There was a problem hiding this comment.
I think one reason is that the Microsoft text editor can kinda handle auto-completion for methods, but mostly fails on anything more complex, like property initializers.
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.