added LionWebVersions 2025.1 and 2025.1-compatible

[enikao]

As of now, content is same as for 2024.1 / 2024.1-compatible

[github-actions]

Test Results

2 905 tests   2 903 ✅  3s ⏱️
    1 suites      2 💤
    1 files        0 ❌

Results for commit 2a6636b.

♻️ This comment has been updated with latest results.

[dslmeinte]

I don't enjoy the code duplication, though! I get it why it's an obvious choice, but I'd much rather would have that there are some base classes that capture the commonality — which is currently 100% between 2024.1 and 2025.1, anyway — and so also clearly state the difference.

[enikao]

I don't enjoy the code duplication, though!

Yes, I agree. IMHO, there's no really good solution here -- either code duplication, or even more convoluted indirection. As the whole "externalize this logic from its actual place to version-specifics" already introduces a lot of indirection, I opted for cutting it here.

Another reason: Old versions should never change their behavior (outside of bug fixes), so it should be a very conscious decision to update old versions.

[dslmeinte]

I don't enjoy the code duplication, though!

Yes, I agree. IMHO, there's no really good solution here -- either code duplication, or even more convoluted indirection. As the whole "externalize this logic from its actual place to version-specifics" already introduces a lot of indirection, I opted for cutting it here.

I was thinking the same as disadvantage of DRY'ing the usual way.

Another reason: Old versions should never change their behavior (outside of bug fixes), so it should be a very conscious decision to update old versions.

Not that having the code duplicated, but still not protected against modification gives a solid guarantee.