Skip to content

Add pre commit integration #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2025

Conversation

UnknownPlatypus
Copy link
Contributor

Fixes #83

This adds basic pre-commit hooks and also does an initial pre-commit run --all-files to fix existing violations (mostly some incorrect end of files)

To enable the automatic CI runs, You'll have to do the necessary setup here. This is free for open source use.

Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (1c1cdec) to head (651beb1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          45       45           
  Lines        7787     7787           
  Branches     2792     2792           
=======================================
  Hits         7687     7687           
  Misses         65       65           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@LilyAcorn LilyAcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

If we can avoid breaking the contents of the invalid.txt test template, I'm happy to merge this.

@UnknownPlatypus UnknownPlatypus force-pushed the add-pre-commit-support branch from 370e9ee to 651beb1 Compare May 4, 2025 14:39
@LilyAcorn LilyAcorn merged commit f4126f8 into LilyAcorn:main May 4, 2025
7 checks passed
@UnknownPlatypus UnknownPlatypus deleted the add-pre-commit-support branch May 4, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce pre-commit?
2 participants