Skip to content

Feature/#607 multiple selection no common props #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions e2e/helpers/properties.helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,13 @@ export const checkPropertiesExist = async (
await expect(propLocator).toBeVisible();
}
};

export const checkPropertiesDoNotExist = async (
page: Page,
properties: string[]
) => {
for (const property of properties) {
const propLocator = page.getByText(property, { exact: true });
await expect(propLocator).not.toBeVisible();
}
};
45 changes: 45 additions & 0 deletions e2e/props/multi-select-no-common-props.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import { test, expect } from '@playwright/test';
import {
addComponentsWithDifferentCategoriesToCanvas,
checkPropertiesDoNotExist,
checkPropertiesExist,
ComponentWithCategory,
getTransformer,
selectAllComponentsInCanvas,
} from '../helpers';

test('when selecting button and bar chart, check that there are not common props (just default layering prop)', async ({
page,
}) => {
page.goto('');

// Add components to canvas
const components: ComponentWithCategory[] = [
{ name: 'Button' },
{ name: 'Bar Chart', category: 'Rich Components' },
];
await addComponentsWithDifferentCategoriesToCanvas(page, components);

// Select all components in canvas
await selectAllComponentsInCanvas(page);

// Confirm both items are selected
const selectedItems = await getTransformer(page);
expect(selectedItems._nodes.length).toEqual(2);

const buttonProps: string[] = [
'Stroke',
'Stroke style',
'Background',
'TextColor',
'Disabled',
'Border-radius',
];

// Verify button props are not visible in the properties panel
await checkPropertiesDoNotExist(page, buttonProps);

// Verify layering prop to be visible

await checkPropertiesExist(page, ['Layering']);
});