Skip to content

[CCV-4605] Add ability to specify relationship constraints #1969 #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 2, 2025
Merged

[CCV-4605] Add ability to specify relationship constraints #1969 #1992

merged 8 commits into from
Jul 2, 2025

Conversation

kjamrozy
Copy link
Contributor

@kjamrozy kjamrozy commented Jul 2, 2025

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@kjamrozy kjamrozy requested a review from a team as a code owner July 2, 2025 16:09
@kjamrozy kjamrozy changed the title [PTDT-4605] Add ability to specify relationship constraints #1969 [CCV-4605] Add ability to specify relationship constraints #1969 Jul 2, 2025
mrobers1982
mrobers1982 requested changes Jul 2, 2025
View reviewed changes
libs/labelbox/src/labelbox/schema/ontology.py
@@ -165,6 +165,8 @@ def tool_cls_from_type(tool_type: str):
tool_cls = map_tool_type_to_tool_cls(tool_type)
if tool_cls is not None:
return tool_cls
if tool_type == Tool.Type.RELATIONSHIP:
return RelationshipTool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this map_tool_type_to_tool_cls for consistency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving it there looks to create a circular dependency, so we will just go with above.

@kjamrozy
Revert "Address CR comment"
0e10bb2 
This reverts commit 3fcfce9.
@kjamrozy kjamrozy merged commit 2343e04 into develop Jul 2, 2025
22 of 26 checks passed
@kjamrozy kjamrozy deleted the kjamrozy/relationship-constraints branch July 2, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobers1982 mrobers1982 mrobers1982 approved these changes

@manastalukdar manastalukdar Awaiting requested review from manastalukdar manastalukdar is a code owner automatically assigned from Labelbox/engineers

@KeshavSahoo KeshavSahoo Awaiting requested review from KeshavSahoo KeshavSahoo is a code owner automatically assigned from Labelbox/engineers

@cyrusj89 cyrusj89 Awaiting requested review from cyrusj89 cyrusj89 is a code owner automatically assigned from Labelbox/engineers

@labelbox-engineering labelbox-engineering Awaiting requested review from labelbox-engineering labelbox-engineering is a code owner automatically assigned from Labelbox/engineers

@ravitatipamula ravitatipamula Awaiting requested review from ravitatipamula ravitatipamula is a code owner automatically assigned from Labelbox/engineers

@snmodi21 snmodi21 Awaiting requested review from snmodi21 snmodi21 is a code owner automatically assigned from Labelbox/engineers

@pslabelbox pslabelbox Awaiting requested review from pslabelbox pslabelbox is a code owner automatically assigned from Labelbox/engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjamrozy @mrobers1982