Skip to content

Add search by name for get_catalog_slice() and get_catalog_slices() #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

paulnoirel
Copy link
Contributor

Description

For FEED-1387 (request for Amazon)

  • Add search by name to get_catalog_slice()
  • Add get_catalog_slices()

Fixes # 0 (issue)

Type of change

Please delete options that are not relevant.

  • [ X] New feature (non-breaking change which adds functionality)

All Submissions

  • [X ] Have you followed the guidelines in our Contributing document?
  • [ X] Have you provided a description?
  • [ X] Are your changes properly formatted?

New Feature Submissions

  • [ X] Does your submission pass tests?
  • [ X] Have you added thorough tests for your new feature?
  • [ X] Have you commented your code, particularly in hard-to-understand areas?
  • [ X] Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@paulnoirel paulnoirel merged commit 30910f4 into develop Feb 18, 2025
21 of 26 checks passed
@paulnoirel paulnoirel deleted the pno/get_slice_by_name branch February 18, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants