Skip to content

[PLT-2290] Fix for mmc test global key #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions libs/labelbox/tests/integration/test_mmc_data_rows.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ def mmc_data_row(dataset):


@pytest.fixture
def mmc_data_row_all(dataset, make_metadata_fields, embedding):
def mmc_data_row_all(dataset, make_metadata_fields, embedding, rand_gen):
data = ModelEvaluationTemplate()
data.row_data.rootMessageIds = ["root1"]
data.global_key = "global_key"
global_key = f"global_key_{rand_gen(str)}"
data.global_key = global_key
vector = [random.uniform(1.0, 2.0) for _ in range(embedding.dims)]
data.embeddings = [{"embedding_id": embedding.id, "vector": vector}]
data.metadata_fields = make_metadata_fields
Expand All @@ -39,7 +40,7 @@ def mmc_data_row_all(dataset, make_metadata_fields, embedding):

data_row = list(dataset.data_rows())[0]

yield data_row
yield data_row, global_key

data_row.delete()

Expand All @@ -57,7 +58,7 @@ def test_mmc(mmc_data_row):


def test_mmc_all(mmc_data_row_all, embedding, constants):
data_row = mmc_data_row_all
data_row, global_key = mmc_data_row_all
assert json.loads(data_row.row_data) == {
"type": "application/vnd.labelbox.conversational.model-chat-evaluation",
"draft": True,
Expand All @@ -66,7 +67,7 @@ def test_mmc_all(mmc_data_row_all, embedding, constants):
"messages": {},
"version": 2,
}
assert data_row.global_key == "global_key"
assert data_row.global_key == global_key
metadata_fields = data_row.metadata_fields
metadata = data_row.metadata
assert len(metadata_fields) == 3
Expand Down
Loading