Skip to content

[PLT-2228] Move to task queue task id to be optional with default as None for better type support #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2024
Merged

[PLT-2228] Move to task queue task id to be optional with default as None for better type support #1929

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e64e7d5
adjusted optional task_queue_id
Gabefire Dec 16, 2024
ba4c5df
fixed linter
Gabefire Dec 16, 2024
1af3e79
adjusted
Gabefire Dec 16, 2024
40e79c4
added in feedback
Gabefire Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libs/labelbox/src/labelbox/schema/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,9 @@ def task_queues(self) -> List[TaskQueue]:
]

def move_data_rows_to_task_queue(
self, data_row_ids: DataRowIdentifiers, task_queue_id: str
self,
data_row_ids: DataRowIdentifiers,
task_queue_id: Optional[str] = None,
):
"""
Expand All @@ -1412,7 +1414,7 @@ def move_data_rows_to_task_queue(
Args:
data_row_ids: a list of data row ids to be moved. This should be a DataRowIdentifiers object
DataRowIdentifier objects are lists of ids or global keys. A DataIdentifier object can be a UniqueIds or GlobalKeys class.
task_queue_id: the task queue id to be moved to, or None to specify the "Done" queue
task_queue_id: the task queue id to be moved to, or None to specify the "Done" queue. Defaults to None.
Returns:
None if successful, or a raised error on failure
Expand Down
Loading