Fix get_roles return type: Dict[str, Role] (instead of List[Role]) #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislav-peharda
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The get_roles method in the Client class (in the libs/labelbox/src/labelbox/client.py file) returns the roles from the get_roles function in the libs/labelbox/src/labelbox/schema/role.py file. This function has return type Dict[str, "Role"], while the method in the Client class has return type List[Role]. This pull request proposes to change the return type of the Client.get_roles method to Dict[str, Role].
Type of change
Bug fix (non-breaking change which fixes an issue).