Skip to content

[PLT-1866][SDK][STEP REASONING] Actions Required for All Variants #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Nov 7, 2024

Description

StepByStep reasoning ontology now requires actions for all variants (even when there are no actions) + new actions added to the Incorrect step

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky marked this pull request as ready for review November 7, 2024 15:12
@vbrodsky vbrodsky requested a review from a team as a code owner November 7, 2024 15:12
@vbrodsky vbrodsky merged commit 7576486 into develop Nov 7, 2024
17 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/fix-step-reasoning-version branch November 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants