Skip to content

[PLT-1691] Simplify get_label_filter_order test #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Nov 6, 2024

Description

The test_label_filter_order test fails consistently on prod for some but not all runs. See here as an example. I have simplified the test to make sure it will be less subjected to timing / concurrency

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/fix-flaky-prod-label-test_PLT-1691 branch from f697bf6 to 7383f4f Compare November 6, 2024 22:32
@vbrodsky vbrodsky force-pushed the VB/fix-flaky-prod-label-test_PLT-1691 branch from 7383f4f to aa890c3 Compare November 6, 2024 22:35
@vbrodsky vbrodsky force-pushed the VB/fix-flaky-prod-label-test_PLT-1691 branch from aa890c3 to eaae556 Compare November 6, 2024 22:38
@vbrodsky vbrodsky force-pushed the VB/fix-flaky-prod-label-test_PLT-1691 branch from eaae556 to d154ba0 Compare November 6, 2024 22:41
@vbrodsky vbrodsky force-pushed the VB/fix-flaky-prod-label-test_PLT-1691 branch from d154ba0 to b602569 Compare November 6, 2024 22:47
@vbrodsky vbrodsky force-pushed the VB/fix-flaky-prod-label-test_PLT-1691 branch from b602569 to d66f913 Compare November 6, 2024 22:49
@vbrodsky vbrodsky force-pushed the VB/fix-flaky-prod-label-test_PLT-1691 branch from 0e48825 to 48c1c5d Compare November 6, 2024 22:56
@vbrodsky vbrodsky changed the title Simplify get_label_filter_order test [PLT-1691] Simplify get_label_filter_order test Nov 6, 2024
@vbrodsky vbrodsky marked this pull request as ready for review November 6, 2024 23:01
@vbrodsky vbrodsky requested a review from a team as a code owner November 6, 2024 23:01
@vbrodsky vbrodsky merged commit 74b076c into develop Nov 7, 2024
17 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/fix-flaky-prod-label-test_PLT-1691 branch November 7, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants