Skip to content

Vb/vb/lbox publishing plt 1701 2 #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Nov 1, 2024

Description

Story: https://labelbox.atlassian.net/browse/PLT-1701

This PR integrates the lbox workflow into our SDK build process, enabling automatic publishing of new lbox libraries with SDK releases.

Goals Not Achieved: Hard-coded library names remain in the provenance step of the lbox workflow.

Discussion: We're using the third-party reusable GitHub workflow slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v2.0.0. In GitHub Actions, reusable workflows run as separate jobs, not steps within a job.

To dynamically build multiple lbox libraries, we need a matrix with dynamic entries. If we could run the provenance workflow as a job step, it would support a dynamic package matrix. However, this isn’t possible with the current setup.

Links:

We do not have 2 lbox packages atm, so the flow will work as is. I will revisit at the end of sprint if I have time

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/VB/lbox-publishing_PLT-1701-2 branch from 281c8e7 to 3f0d20a Compare November 1, 2024 16:49
@vbrodsky vbrodsky force-pushed the VB/VB/lbox-publishing_PLT-1701-2 branch from 3f0d20a to 83d068f Compare November 1, 2024 16:51
@vbrodsky vbrodsky force-pushed the VB/VB/lbox-publishing_PLT-1701-2 branch from 83d068f to 0ea6536 Compare November 1, 2024 16:53
@vbrodsky vbrodsky force-pushed the VB/VB/lbox-publishing_PLT-1701-2 branch from 0ea6536 to 016f4d7 Compare November 1, 2024 16:54
@vbrodsky vbrodsky force-pushed the VB/VB/lbox-publishing_PLT-1701-2 branch from 016f4d7 to 156c1d1 Compare November 1, 2024 17:02
@vbrodsky vbrodsky force-pushed the VB/VB/lbox-publishing_PLT-1701-2 branch from 156c1d1 to aa86677 Compare November 1, 2024 17:04
@vbrodsky vbrodsky temporarily deployed to publish-lbox-clients November 1, 2024 17:06 — with GitHub Actions Inactive
@vbrodsky vbrodsky force-pushed the VB/VB/lbox-publishing_PLT-1701-2 branch from aa86677 to 1ac6d7d Compare November 1, 2024 17:08
@vbrodsky vbrodsky marked this pull request as ready for review November 1, 2024 20:42
@vbrodsky vbrodsky requested a review from a team as a code owner November 1, 2024 20:42
@vbrodsky vbrodsky merged commit ad26d57 into develop Nov 1, 2024
12 checks passed
@vbrodsky vbrodsky deleted the VB/VB/lbox-publishing_PLT-1701-2 branch November 1, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants