Skip to content

[PLT-1684] Vb/step reasoning ontology plt 1684 #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Oct 22, 2024

Description

Story: https://labelbox.atlassian.net/browse/PLT-1684

This implements sdk support for StepReasoning ontology feature

Notes:

  • requirements: here and here
  • this feature in a number of respects is different from all other Tools we have implemented so far:
    • it does not support classifications
    • it allows for very little customization
    • it has a definition field, something other Tool(s) do not
    • so I have made it a separate class
  • from the implementation perspective, ontology tools / classifications are dataclasses, not pydantic models. They require a little more coding and also we are doing things 'somewhat differently' as a result. I will add a story to convert these classes pydantic models for consistency (and should result in removing some code)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/step-reasoning-ontology_PLT-1684 branch from 01b292c to 9207b07 Compare October 22, 2024 23:16
@vbrodsky vbrodsky force-pushed the VB/step-reasoning-ontology_PLT-1684 branch from 9207b07 to 09d589c Compare October 22, 2024 23:23
@vbrodsky vbrodsky force-pushed the VB/step-reasoning-ontology_PLT-1684 branch from 09d589c to 8f7bcf1 Compare October 22, 2024 23:41
@vbrodsky vbrodsky force-pushed the VB/step-reasoning-ontology_PLT-1684 branch from 8f7bcf1 to b34b11c Compare October 23, 2024 18:25
@vbrodsky vbrodsky changed the title Vb/step reasoning ontology plt 1684 [PLT-1684] Vb/step reasoning ontology plt 1684 Oct 23, 2024
@vbrodsky vbrodsky marked this pull request as ready for review October 23, 2024 22:07
@vbrodsky vbrodsky requested a review from a team as a code owner October 23, 2024 22:07
@vbrodsky vbrodsky force-pushed the VB/step-reasoning-ontology_PLT-1684 branch from ff0bd00 to 86e34ec Compare October 25, 2024 18:22
@vbrodsky vbrodsky force-pushed the VB/step-reasoning-ontology_PLT-1684 branch from 4e42a20 to fa29d2b Compare October 28, 2024 21:28
@vbrodsky vbrodsky force-pushed the VB/step-reasoning-ontology_PLT-1684 branch from 7854dfb to b8f412b Compare October 28, 2024 22:14
@vbrodsky vbrodsky merged commit cbc6d95 into develop Oct 28, 2024
19 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/step-reasoning-ontology_PLT-1684 branch October 28, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants