Skip to content

[PLT-1659] Fix handling of global key in ModelEvaluationTemplate #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[PLT-1659] Fix handling of global key in ModelEvaluationTemplate #1869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/labelbox/src/labelbox/schema/data_row_payload_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class ModelEvalutationTemplateRowData(BaseModel):
actors: Dict = Field(default={})
version: int = Field(default=2, frozen=True)
messages: Dict = Field(default={})
global_key: Optional[str] = None


class ModelEvaluationTemplate(BaseModel):
Expand All @@ -36,6 +35,7 @@ class ModelEvaluationTemplate(BaseModel):
row_data: ModelEvalutationTemplateRowData = Field(
default=ModelEvalutationTemplateRowData()
)
global_key: Optional[str] = None
attachments: List[Dict] = Field(default=[])
embeddings: List[Dict] = Field(default=[])
metadata_fields: List[DataRowMetadataField] = Field(default=[])
5 changes: 2 additions & 3 deletions libs/labelbox/tests/integration/test_mmc_data_rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def mmc_data_row(dataset):
def mmc_data_row_all(dataset, make_metadata_fields, embedding):
data = ModelEvaluationTemplate()
data.row_data.rootMessageIds = ["root1"]
data.row_data.global_key = "global_key"
data.global_key = "global_key"
vector = [random.uniform(1.0, 2.0) for _ in range(embedding.dims)]
data.embeddings = [{"embedding_id": embedding.id, "vector": vector}]
data.metadata_fields = make_metadata_fields
Expand Down Expand Up @@ -65,9 +65,8 @@ def test_mmc_all(mmc_data_row_all, embedding, constants):
"actors": {},
"messages": {},
"version": 2,
"globalKey": "global_key",
}

assert data_row.global_key == "global_key"
metadata_fields = data_row.metadata_fields
metadata = data_row.metadata
assert len(metadata_fields) == 3
Expand Down
Loading