Skip to content

Vb/merge 5.2 2 #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 11, 2024
Merged

Vb/merge 5.2 2 #1867

merged 24 commits into from
Oct 11, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Oct 10, 2024

Description

This PR is a merge of v.5.2.0 and 5.2.1 updates + some last minute changes

  • Updated create_model_evaluation_project because we have switched to named parameters for create_project in v1
  • Cherry-picked Gabe's update to warnings for export_v2
  • Made sure it is clear we do not support p 3.13 officially yet (although I think code prob would work)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky marked this pull request as ready for review October 10, 2024 23:54
@vbrodsky vbrodsky requested a review from a team as a code owner October 10, 2024 23:54
@vbrodsky vbrodsky merged commit 6368b93 into v6 Oct 11, 2024
18 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/merge_5.2-2 branch October 11, 2024 00:38
vbrodsky added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Michał Jóźwiak <mjozwiak@labelbox.com>
Co-authored-by: Gabe <33893811+Gabefire@users.noreply.github.com>
Co-authored-by: sfendell-labelbox <150080555+sfendell-labelbox@users.noreply.github.com>
Co-authored-by: mnoszczak <99751601+mnoszczak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants