Skip to content

[PLT-1580] Cleaned up typed array #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

[PLT-1580] Cleaned up typed array #1858

merged 2 commits into from
Oct 8, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Oct 8, 2024 •
edited
Loading

Description

  • Support Numpy 2.0 now that we are not supporting 3.8
  • limit Numpy to over 1.25, which came out over a year ago, and we only supported 1.24.4> anyways
  • allows us to clean up a messy class that does not behave well with editors

@Gabefire Gabefire requested a review from a team as a code owner October 8, 2024 21:54
@Gabefire Gabefire changed the title Cleaned up typed array DRAFT [PLT-1580] Cleaned up typed array Oct 8, 2024
@Gabefire Gabefire merged commit 8e89cec into v6 Oct 8, 2024
16 of 23 checks passed
@Gabefire Gabefire deleted the gu/clean_up_typed_array branch October 8, 2024 23:11
vbrodsky pushed a commit that referenced this pull request Oct 11, 2024
@Gabefire
[PLT-1580] Cleaned up typed array (#1858)
da0b644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuaero manuaero manuaero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabefire @manuaero