[PLT-1614] Support data row / batch for live mmc projects #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/placeholder-datarows-PLT-1611
branch
from
6a54b27 to
60124d5
Compare
vbrodsky
commented
Oct 8, 2024
| @@ -788,7 +781,9 @@ def create_batch( | |||
| if self.queue_mode != QueueMode.Batch: | |||
| raise ValueError("Project must be in batch mode") | |||
|
|
|||
| if self.is_auto_data_generation(): | |||
| if ( | |||
| self.is_auto_data_generation() and not self.is_chat_evaluation() | |||
There was a problem hiding this comment.
we now will allow to create batches for live mmc project
added 3 commits
October 8, 2024 10:56
Exclude live mmc project from auto upload check Add helper to generate mmc data row payload Create live mmc project without autogenerated data rows
vbrodsky
force-pushed
the
VB/placeholder-datarows-PLT-1611
branch
from
60124d5 to
588191e
Compare
vbrodsky
changed the title
manuaero
approved these changes
Oct 8, 2024
vbrodsky
added a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: https://labelbox.atlassian.net/browse/PLT-1614
Made updates to allow the same handling for live mmc projets as all other projects:
ModelEvalutationTemlateRowDataclass to make it easier generate row_data for MMC live data rows upload (use is optional but should be encouraged in our docs)create_model_evaluation_projectto support both scenarios: legacy one when data rows and datasets are created and a new one when just a project is created. This logic is controlled on BE via a feature flagType of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features