[PLT-1487] Remaining sdk deprecated items removed #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
approved these changes
Oct 8, 2024
vbrodsky
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing:
get_data_row_ids_for_global_keys - decide whether to update the deprecation notice and rdoc if the change in the api took place OR remove the deprecation notice
LabelGenerator assign_feature_schema_ids
AttachmentType remove TEXT
DataRowMetadataOntology bulk_delete. bulk_export - we will keep strings, remove deprecation warnings
Dataset create_data_rows_sync
QueueMode (value=='CATALOG')
CatalogSlice get_data_row_ids
NOTE: I completely removed queue mode as a field on this PR. No project exists in Labelbox that is not Batch since we migrated all projects. You can not have any other queue mode besides Batch so no point of including. The API side was giving me some weird responses