-
Notifications
You must be signed in to change notification settings - Fork 68
[PLT-1154] Vb/refactor project inputs plt 1154 #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b68f6d6
to
6204d5f
Compare
vbrodsky
commented
Sep 24, 2024
@@ -53,7 +53,7 @@ def evaluate_ontology_kind_with_media_type( | |||
return media_type | |||
|
|||
|
|||
class EditorTaskType(Enum): | |||
class EditorTaskType(str, Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed to support json serializaiton
70db938
to
55ba6b5
Compare
55ba6b5
to
dd9fbb4
Compare
c16218a
to
2c5cca7
Compare
2c5cca7
to
f9a7147
Compare
sfendell-labelbox
approved these changes
Sep 25, 2024
…luation_project, create_offline_model_evaluation_project, create_prompt_response_generation_project, create_response_creation_project
f9a7147
to
e1b7f66
Compare
sfendell-labelbox
approved these changes
Sep 25, 2024
vbrodsky
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes made:
create_project_...
methods replaced kwargs with named inputs_create_project
media_type
required as per deprecation warningqueue_mode
from inputs, setting it toBatch
by default as per deprecation warningType of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features