Skip to content

[PLT-1154] Vb/refactor project inputs plt 1154 #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 25, 2024
Merged

[PLT-1154] Vb/refactor project inputs plt 1154 #1844

merged 7 commits into from
Sep 25, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 24, 2024 •
edited
Loading

Description

Changes made:

  • For all create_project_... methods replaced kwargs with named inputs
  • Added a pydantic model to validate all inputs in _create_project
  • Made media_type required as per deprecation warning
  • Removed queue_mode from inputs, setting it to Batch by default as per deprecation warning

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/refactor-project-inputs_PLT-1154 branch from b68f6d6 to 6204d5f Compare September 24, 2024 23:18
vbrodsky
vbrodsky commented Sep 24, 2024
View reviewed changes
libs/labelbox/src/labelbox/schema/ontology_kind.py
@@ -53,7 +53,7 @@ def evaluate_ontology_kind_with_media_type(
return media_type


class EditorTaskType(Enum):
class EditorTaskType(str, Enum):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to support json serializaiton

@vbrodsky vbrodsky force-pushed the VB/refactor-project-inputs_PLT-1154 branch from 70db938 to 55ba6b5 Compare September 25, 2024 00:25
@vbrodsky vbrodsky force-pushed the VB/refactor-project-inputs_PLT-1154 branch from 55ba6b5 to dd9fbb4 Compare September 25, 2024 00:41
@vbrodsky vbrodsky force-pushed the VB/refactor-project-inputs_PLT-1154 branch from c16218a to 2c5cca7 Compare September 25, 2024 16:33
@vbrodsky vbrodsky changed the title Vb/refactor project inputs plt 1154 [PLT-1154] Vb/refactor project inputs plt 1154 Sep 25, 2024
@vbrodsky vbrodsky marked this pull request as ready for review September 25, 2024 18:06
@vbrodsky vbrodsky requested a review from a team as a code owner September 25, 2024 18:06
@vbrodsky vbrodsky force-pushed the VB/refactor-project-inputs_PLT-1154 branch from 2c5cca7 to f9a7147 Compare September 25, 2024 21:25
Val Brodsky added 6 commits September 25, 2024 15:13
Use _CoreProjectInput in all create_project methods, create_model_eva…
1f4a377 
…luation_project, create_offline_model_evaluation_project, create_prompt_response_generation_project, create_response_creation_project
Added media_type to test projects
8a36b7b
Removed queue_mode
1ada7be
Update rdoc
cd5567f
Remove auto_audit inputs
6c16f43
Remove unnecessary test
e1b7f66
@vbrodsky vbrodsky force-pushed the VB/refactor-project-inputs_PLT-1154 branch from f9a7147 to e1b7f66 Compare September 25, 2024 22:15
@vbrodsky vbrodsky merged commit 1142435 into v6 Sep 25, 2024
17 of 26 checks passed
@vbrodsky vbrodsky deleted the VB/refactor-project-inputs_PLT-1154 branch September 25, 2024 22:32
vbrodsky added a commit that referenced this pull request Oct 11, 2024
@vbrodsky
[PLT-1154] Vb/refactor project inputs plt 1154 (#1844)
d4986a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfendell-labelbox sfendell-labelbox sfendell-labelbox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbrodsky @sfendell-labelbox