[PLT-1485] Removed Datatypes #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gabe <33893811+Gabefire@users.noreply.github.com>
…ython into gu/remove_data_types
Gabefire
commented
Sep 19, 2024
| @@ -40,26 +40,6 @@ def _assign_ids(label: Label): | |||
| self._fns["assign_feature_schema_ids"] = _assign_ids | |||
| return self | |||
|
|
|||
| def add_url_to_data( | |||
There was a problem hiding this comment.
Removed this function. This is not supported by GenericDataType and I do not think this is relevant any longer. Check doc string for what it does
Gabefire
commented
Sep 19, 2024
| @@ -91,37 +93,23 @@ def test_adding_schema_ids(): | |||
| assert next(generator).annotations[0].feature_schema_id == feature_schema_id | |||
|
|
|||
|
|
|||
| def test_adding_urls(signer): | |||
There was a problem hiding this comment.
Removed due to removing function
…ython into gu/remove_data_types
vbrodsky
approved these changes
Sep 23, 2024
| @@ -232,7 +232,7 @@ def from_common( | |||
| name: str, | |||
| feature_schema_id: Cuid, | |||
| extra: Dict[str, Any], | |||
| data: Union[TextData, ImageData], | |||
| data: Union[GenericDataRowData], | |||
There was a problem hiding this comment.
do we really need Union here?
| @@ -264,7 +264,7 @@ def from_common( | |||
| name: str, | |||
| feature_schema_id: Cuid, | |||
| extra: Dict[str, Any], | |||
| data: Union[VideoData, TextData, ImageData], | |||
| data: Union[GenericDataRowData], | |||
vbrodsky
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Geotile has to stay because it has parameters that are need for the label like zoom level