Skip to content

Vb/merge 5.0.0 #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Vb/merge 5.0.0 #1826

merged 4 commits into from
Sep 18, 2024

Conversation

vbrodsky
Copy link
Contributor

Description

Rebase commits from develop into the v6 branch

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner September 17, 2024 21:57
adrian-chang
adrian-chang previously approved these changes Sep 17, 2024
@vbrodsky vbrodsky merged commit 2faf9a1 into develop Sep 18, 2024
18 of 26 checks passed
@vbrodsky vbrodsky deleted the VB/merge-5.0.0 branch September 18, 2024 16:01
vbrodsky pushed a commit that referenced this pull request Sep 18, 2024
@vbrodsky vbrodsky restored the VB/merge-5.0.0 branch September 18, 2024 16:04
vbrodsky added a commit that referenced this pull request Sep 18, 2024
vbrodsky added a commit that referenced this pull request Oct 10, 2024
Co-authored-by: Gabe <33893811+Gabefire@users.noreply.github.com>
vbrodsky added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants