[PLT-1506] Added Ruff linting to SDK

.github/workflows/lbox-develop.yml

@@ -2,9 +2,9 @@ name: LBox Develop
 
 on:
   push:
-    branches: [develop]
+    branches: [develop, v6]
   pull_request:
-    branches: [develop]
+    branches: [develop, v6]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}

.github/workflows/python-package-develop.yml

@@ -2,9 +2,9 @@ name: Labelbox Python SDK Staging (Develop)
 
 on:
   push:
-    branches: [develop]
+    branches: [develop, v6]
   pull_request:
-    branches: [develop]
+    branches: [develop, v6]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}

libs/labelbox/pyproject.toml

@@ -74,6 +74,10 @@ dev-dependencies = [
 [tool.ruff]
 line-length = 80
 
+[tool.ruff.lint]
+ignore = ["F", "E722"]
+exclude = ["**/__init__.py"]
+
 [tool.rye.scripts]
 unit = "pytest tests/unit"
 # https://github.com/Labelbox/labelbox-python/blob/7c84fdffbc14fd1f69d2a6abdcc0087dc557fa4e/Makefile
@@ -89,9 +93,10 @@ unit = "pytest tests/unit"
 # LABELBOX_TEST_BASE_URL="http://host.docker.internal:8080" \
 integration = { cmd = "pytest tests/integration" }
 data = { cmd = "pytest tests/data" }
+rye-lint = "rye lint"
 rye-fmt-check = "rye fmt --check"
 mypy-lint = "mypy src --pretty --show-error-codes --non-interactive --install-types"
-lint = { chain = ["mypy-lint", "rye-fmt-check"] }
+lint = { chain = ["rye-fmt-check", "mypy-lint", "rye-lint"] }
 test = { chain = ["lint", "unit", "integration"] }
 
 [tool.hatch.metadata]

libs/labelbox/src/labelbox/client.py

@@ -626,7 +626,7 @@ def _get_all(self, db_object_type, where, filter_deleted=True):
             An iterable of `db_object_type` instances.
         """
         if filter_deleted:
-            not_deleted = db_object_type.deleted == False
+            not_deleted = db_object_type.deleted is False
             where = not_deleted if where is None else where & not_deleted
         query_str, params = query.get_all(db_object_type, where)
 
@@ -2297,11 +2297,11 @@ def delete_feature_schema_from_ontology(
 
         if response.status_code == requests.codes.ok:
             response_json = response.json()
-            if response_json["archived"] == True:
+            if response_json["archived"] is True:
                 logger.info(
                     "Feature schema was archived from the ontology because it had associated labels."
                 )
-            elif response_json["deleted"] == True:
+            elif response_json["deleted"] is True:
                 logger.info(
                     "Feature schema was successfully removed from the ontology"
                 )

libs/labelbox/src/labelbox/data/annotation_types/data/raster.py

@@ -172,7 +172,7 @@ def validate_args(self, values):
         uid = self.uid
         global_key = self.global_key
         if (
-            uid == file_path == im_bytes == url == global_key == None
+            uid == file_path == im_bytes == url == global_key is None
             and arr is None
         ):
             raise ValueError(
@@ -191,7 +191,9 @@ def validate_args(self, values):
         return self
 
     def __repr__(self) -> str:
-        symbol_or_none = lambda data: "..." if data is not None else None
+        def symbol_or_none(data):
+            return "..." if data is not None else None
+
         return (
             f"{self.__class__.__name__}(im_bytes={symbol_or_none(self.im_bytes)},"
             f"file_path={self.file_path},"

libs/labelbox/src/labelbox/data/annotation_types/data/text.py

@@ -101,7 +101,7 @@ def validate_date(self, values):
         url = self.url
         uid = self.uid
         global_key = self.global_key
-        if uid == file_path == text == url == global_key == None:
+        if uid == file_path == text == url == global_key is None:
             raise ValueError(
                 "One of `file_path`, `text`, `uid`, `global_key` or `url` required."
             )

libs/labelbox/src/labelbox/data/annotation_types/data/video.py

@@ -159,7 +159,7 @@ def validate_data(self):
         uid = self.uid
         global_key = self.global_key
 
-        if uid == file_path == frames == url == global_key == None:
+        if uid == file_path == frames == url == global_key is None:
             raise ValueError(
                 "One of `file_path`, `frames`, `uid`, `global_key` or `url` required."
             )

libs/labelbox/src/labelbox/data/annotation_types/video.py

@@ -125,7 +125,7 @@ class MaskFrame(_CamelCaseMixin, BaseModel):
     def validate_args(self, values):
         im_bytes = self.im_bytes
         instance_uri = self.instance_uri
-        if im_bytes == instance_uri == None:
+        if im_bytes == instance_uri is None:
             raise ValueError("One of `instance_uri`, `im_bytes` required.")
         return self
 

libs/labelbox/src/labelbox/data/metrics/confusion_matrix/calculation.py

@@ -130,7 +130,7 @@ def classification_confusion_matrix(
 
     prediction, ground_truth = predictions[0], ground_truths[0]
 
-    if type(prediction) != type(ground_truth):
+    if type(prediction) is not type(ground_truth):
         raise TypeError(
             "Classification features must be the same type to compute agreement. "
             f"Found `{type(prediction)}` and `{type(ground_truth)}`"

libs/labelbox/src/labelbox/data/metrics/iou/calculation.py

@@ -209,7 +209,7 @@ def classification_miou(
 
     prediction, ground_truth = predictions[0], ground_truths[0]
 
-    if type(prediction) != type(ground_truth):
+    if type(prediction) is not type(ground_truth):
         raise TypeError(
             "Classification features must be the same type to compute agreement. "
             f"Found `{type(prediction)}` and `{type(ground_truth)}`"

libs/labelbox/src/labelbox/data/serialization/__init__.py

@@ -1,2 +1 @@
 from .ndjson import NDJsonConverter
-from .coco import COCOConverter