Skip to content

V6 #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 11, 2024
Merged

V6 #1819

merged 29 commits into from
Oct 11, 2024

Conversation

vbrodsky
Copy link
Contributor

Description

Please holder PR to make sure we generate tet-pypi and containers for the release feature branch

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner September 16, 2024 18:41
@vbrodsky vbrodsky marked this pull request as draft September 16, 2024 18:41
Gabefire
Gabefire reviewed Sep 18, 2024
View reviewed changes
.github/workflows/lbox-develop.yml Outdated
@@ -2,9 +2,9 @@ name: LBox Develop

on:
push:
branches: [develop]
branches: [develop, v6]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we need to remove v6 from the workflows before merging to develop. These are here temporary for tests to run

@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients September 23, 2024 18:54 — with GitHub Actions Inactive
@Gabefire Gabefire temporarily deployed to Test-PyPI-lbox-clients September 23, 2024 21:30 — with GitHub Actions Inactive
@Gabefire Gabefire temporarily deployed to Test-PyPI-lbox-clients September 25, 2024 16:47 — with GitHub Actions Inactive
@Gabefire Gabefire temporarily deployed to Test-PyPI-lbox-clients September 25, 2024 17:00 — with GitHub Actions Inactive
@Gabefire Gabefire temporarily deployed to Test-PyPI-lbox-clients September 25, 2024 17:41 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients September 25, 2024 22:35 — with GitHub Actions Inactive
@Gabefire Gabefire temporarily deployed to Test-PyPI-lbox-clients September 26, 2024 16:46 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients September 26, 2024 21:07 — with GitHub Actions Inactive
@Gabefire Gabefire temporarily deployed to Test-PyPI-lbox-clients September 26, 2024 21:27 — with GitHub Actions Inactive
@vbrodsky @real-mjozwiak
@Gabefire @sfendell-labelbox @mnoszczak
Vb/merge 5.2 2 (#1867)
50e917d 
Co-authored-by: Michał Jóźwiak <mjozwiak@labelbox.com>
Co-authored-by: Gabe <33893811+Gabefire@users.noreply.github.com>
Co-authored-by: sfendell-labelbox <150080555+sfendell-labelbox@users.noreply.github.com>
Co-authored-by: mnoszczak <99751601+mnoszczak@users.noreply.github.com>
@vbrodsky vbrodsky marked this pull request as ready for review October 11, 2024 18:20
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients October 11, 2024 18:33 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-example October 11, 2024 18:33 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients October 11, 2024 18:45 — with GitHub Actions Inactive
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-example October 11, 2024 18:45 — with GitHub Actions Inactive
@vbrodsky
Copy link
Contributor Author

Latest test runs https://github.com/Labelbox/labelbox-python/actions/runs/11297671151

@vbrodsky vbrodsky merged commit 6fb945c into develop Oct 11, 2024
2 checks passed
@vbrodsky vbrodsky deleted the v6 branch October 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-chang adrian-chang adrian-chang approved these changes

@Gabefire Gabefire Gabefire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbrodsky @adrian-chang @Gabefire