Skip to content

Vb/fix ontology leaks plt 1379 #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 13, 2024

Description

Story: https://labelbox.atlassian.net/browse/PLT-1379

Our sdk integration tests do not delete any schema nodes and as a result we 'leak' about 1,600 schema nodes per run. Original goal of this story was to delete all schema nodes, but it turns out our api has limitation in that it only deletes root nodes.

I have refactored code and added a helper to project fixtures to cleanup project and all it's dependencies including schema nodes. Unfortunately it will not result in drastic reduction of leaked schema nodes as per above.

Still, if and when the api supports deletion of all schema nodes, test update will be easy

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/fix-ontology-leaks_PLT-1379 branch from b72e044 to 43b55d0 Compare September 16, 2024 18:31
@vbrodsky vbrodsky force-pushed the VB/fix-ontology-leaks_PLT-1379 branch from 43b55d0 to 2be6dbb Compare September 16, 2024 18:58
@vbrodsky vbrodsky marked this pull request as ready for review September 16, 2024 19:56
@vbrodsky vbrodsky requested a review from a team as a code owner September 16, 2024 19:56
Refactor teardown handling into a separate helper

Removed unused fixture
@vbrodsky vbrodsky force-pushed the VB/fix-ontology-leaks_PLT-1379 branch from 2be6dbb to cc423a6 Compare September 16, 2024 20:02
@@ -23,21 +25,11 @@
from labelbox.schema.queue_mode import QueueMode
from labelbox import Client

from labelbox import Dataset, DataRow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used ruff to delete unused imports

@vbrodsky vbrodsky merged commit 0bbd7c2 into develop Sep 17, 2024
18 of 26 checks passed
@vbrodsky vbrodsky deleted the VB/fix-ontology-leaks_PLT-1379 branch September 17, 2024 01:05
vbrodsky added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants