Skip to content

[PLT-1339] Fixed Cuid dependencies that crash if numpy was not installed #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 11, 2024

Description

This addresses the issue when a class importing a Cuid type ended up dragging other classes that used numpy that is an optional package

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner September 11, 2024 20:23
@vbrodsky vbrodsky changed the title Fixed Cuid dependencies that crash if numpy was not installed [PLT-1339] Fixed Cuid dependencies that crash if numpy was not installed Sep 11, 2024
adrian-chang
adrian-chang previously approved these changes Sep 11, 2024
@vbrodsky vbrodsky merged commit cc9d6af into develop Sep 11, 2024
17 of 25 checks passed
@vbrodsky vbrodsky deleted the VB/fix-cuid_PLT-1339 branch September 11, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants