Skip to content

[PLT-1495] Migrated sdk to use Ruff for formattor #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 12, 2024
Merged

[PLT-1495] Migrated sdk to use Ruff for formattor #1806

merged 10 commits into from
Sep 12, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Sep 11, 2024

Description

  • Swapping Yapf to Ruff, which is built into Rye
  • Ruff is 100x times faster then Yapf with more features
  • The reason why every file was touched is people have not been using Yapf, our checker has not been enforcing it in the workflow. If you run rye run yapf-lint it touchs almost all files so I don't think it has been running.
  • I added on to the limiting workflow to start enforcing the formattor

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

@Gabefire Gabefire requested a review from a team as a code owner September 11, 2024 20:01
@Gabefire Gabefire changed the title testing workflow [PLT-1495] Migrated sdk to use Ruff for formattor Sep 11, 2024
@Gabefire Gabefire merged commit 4250004 into develop Sep 12, 2024
19 of 26 checks passed
@Gabefire Gabefire deleted the gu/test branch September 12, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants