Skip to content

Vb/test multiple sdk versions plt 1320 #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 6, 2024

Description

We now pull 4 latest sdk releases and run testing for all PRs to develop. Oldest release is assigned to the oldest python version and current branch code runs off the latest python version.

Lints remains as is - all python versions for current branch

Prod remains as is - only latest release on all python versions

Screenshot 2024-09-06 at 12 31 45 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/test-multiple-sdk-versions_PLT-1320 branch 2 times, most recently from 6133a4a to c3fa178 Compare September 6, 2024 19:05
@vbrodsky vbrodsky force-pushed the VB/test-multiple-sdk-versions_PLT-1320 branch from aecfbce to 18a1208 Compare September 6, 2024 19:25
@vbrodsky vbrodsky force-pushed the VB/test-multiple-sdk-versions_PLT-1320 branch from 6929090 to 5afd99f Compare September 6, 2024 21:06
@vbrodsky vbrodsky marked this pull request as ready for review September 6, 2024 21:56
@vbrodsky vbrodsky requested a review from a team as a code owner September 6, 2024 21:56
@vbrodsky vbrodsky force-pushed the VB/test-multiple-sdk-versions_PLT-1320 branch from b9cc12c to 0d8dd40 Compare September 9, 2024 16:46
@vbrodsky vbrodsky merged commit e74b5d8 into develop Sep 9, 2024
12 checks passed
@vbrodsky vbrodsky deleted the VB/test-multiple-sdk-versions_PLT-1320 branch September 9, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants