Skip to content

Vb/fixes and improvements 3 #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Vb/fixes and improvements 3 #1784

merged 4 commits into from
Aug 29, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Aug 28, 2024

Description

Next batch of fixes and improvements for sdk / project list integration:

  • switch from task* to dataRows* fields because the task fields do not work correctly
  • add validation to the ProjectStageFilter
  • fix flaky test
  • add support for the TagFilter

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner August 28, 2024 23:08
@vbrodsky vbrodsky force-pushed the VB/fixes-and-improvements-3 branch from 0ae34bb to 00b2cfe Compare August 28, 2024 23:58
with pytest.raises(
ValueError,
match="is not a valid value for ProjectStageFilter") as e:
_ = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semi-nit: Let's just instantiate the ProjectStageFilter object here? No need to put it in an array or assign it to a dummy var

@vbrodsky vbrodsky merged commit 04d6e75 into develop Aug 29, 2024
19 of 25 checks passed
@vbrodsky vbrodsky deleted the VB/fixes-and-improvements-3 branch August 29, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants