-
Notifications
You must be signed in to change notification settings - Fork 68
[PLT-1421]Build test-py-pi for a dev merge even if tests fail #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -60,7 +60,9 @@ jobs: | |||
secrets: inherit | |||
test-pypi: | |||
runs-on: ubuntu-latest | |||
if: github.event_name == 'push' && github.ref == 'refs/heads/develop' | |||
needs: ['build'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs: ['path-filter']
don't make it depend on tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other change (if etc. continue on error isn't needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, make test-container only depend on needs: ['path-filter'] and not on tests
0173d8b
to
2139a4a
Compare
2139a4a
to
125fcac
Compare
8b26c9b
to
739446f
Compare
Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features