Skip to content

[PLT-1421]Build test-py-pi for a dev merge even if tests fail #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Aug 21, 2024

Description

  1. Need to make sure we build our library on test-pypi for ALL dev merges
  2. Will tell QA to use a different command in their collab to pull it test-pypi. The command they use now will not work

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner August 21, 2024 21:12
@vbrodsky vbrodsky changed the title [PLT-0]Build test-py-pi for a dev merge even if tests fail [PLT-1421]Build test-py-pi for a dev merge even if tests fail Aug 21, 2024
@@ -60,7 +60,9 @@ jobs:
secrets: inherit
test-pypi:
runs-on: ubuntu-latest
if: github.event_name == 'push' && github.ref == 'refs/heads/develop'
needs: ['build']
Copy link
Contributor

@adrian-chang adrian-chang Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs: ['path-filter']
don't make it depend on tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other change (if etc. continue on error isn't needed)

Copy link
Contributor

@adrian-chang adrian-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, make test-container only depend on needs: ['path-filter'] and not on tests

@vbrodsky vbrodsky requested a review from adrian-chang August 21, 2024 21:54
@vbrodsky vbrodsky merged commit e19673d into develop Aug 22, 2024
11 checks passed
@vbrodsky vbrodsky deleted the VB/make-qa-build branch August 22, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants