Skip to content

Vb/search projects filters plt 1399 #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Aug 18, 2024

Description

Add search filters to project list

Story: https://labelbox.atlassian.net/browse/PLT-1399

Methods updated:

  • Client get_labeling_service_dashboards
  • LabelingServiceDashboard.get_all

Adds API/ES search filters as pydantic classes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/search-projects-filters_PLT-1399 branch 4 times, most recently from 50fbf77 to 92f29e0 Compare August 18, 2024 23:05
@vbrodsky vbrodsky marked this pull request as ready for review August 19, 2024 16:04
@vbrodsky vbrodsky requested a review from a team as a code owner August 19, 2024 16:04
@vbrodsky vbrodsky force-pushed the VB/search-projects-filters_PLT-1399 branch from 35838f0 to 2bd487a Compare August 19, 2024 21:03
return "[" + ", ".join(
_dict_to_graphql_string(item) for item in d) + "]"
else:
return f'"{d}"' if isinstance(d, str) else str(d)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to surround numbers with quotations too? Maybe doesn't matter currently since I don't think any of the filters currently use one, but if we do we should do that now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the quotations are only if isinstance(d, str). You are right we need to test this code with numbers. Currently we do not have any, but I will do it in a follow up story for a new filter we are creating

@vbrodsky vbrodsky force-pushed the VB/search-projects-filters_PLT-1399 branch from 96aa99c to 41d27eb Compare August 20, 2024 18:35
@vbrodsky vbrodsky merged commit bf30f08 into develop Aug 20, 2024
18 of 24 checks passed
@vbrodsky vbrodsky deleted the VB/search-projects-filters_PLT-1399 branch August 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants