-
Notifications
You must be signed in to change notification settings - Fork 68
Vb/search projects filters plt 1399 #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
50fbf77
to
92f29e0
Compare
35838f0
to
2bd487a
Compare
2bd487a
to
96aa99c
Compare
return "[" + ", ".join( | ||
_dict_to_graphql_string(item) for item in d) + "]" | ||
else: | ||
return f'"{d}"' if isinstance(d, str) else str(d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to surround numbers with quotations too? Maybe doesn't matter currently since I don't think any of the filters currently use one, but if we do we should do that now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the quotations are only if isinstance(d, str)
. You are right we need to test this code with numbers. Currently we do not have any, but I will do it in a follow up story for a new filter we are creating
41d27eb
96aa99c
to
41d27eb
Compare
Description
Add search filters to project list
Story: https://labelbox.atlassian.net/browse/PLT-1399
Methods updated:
Adds API/ES search filters as pydantic classes
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features