Skip to content

[PLT-1359] Vb/labeling service improve message reporting plt 1359 #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Aug 12, 2024

Description

Story: https://labelbox.atlassian.net/browse/PLT-1359

Improvements to error reporting for labeling service request()

Before:

labelbox.exceptions.LabelboxError:  [{"errorType":"DATA_STEP","errorMessage":"Data is missing"},{"errorType":"ONTOLOGY_INSTRUCTIONS","errorMessage":"Ontology instructions are not completed"}], None"

After:

labelbox.exceptions.LabelboxError: Data is missing. Ontology instructions are not completed('Data is missing. Ontology instructions are not completed')

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner August 12, 2024 23:31
@vbrodsky vbrodsky force-pushed the VB/labeling-service-improve-message-reporting_PLT-1359 branch from 5f5dfe4 to f886386 Compare August 12, 2024 23:43
@vbrodsky vbrodsky force-pushed the VB/labeling-service-improve-message-reporting_PLT-1359 branch from f886386 to aea30f1 Compare August 14, 2024 17:23
@vbrodsky vbrodsky merged commit 6252ea9 into develop Aug 15, 2024
15 of 24 checks passed
@vbrodsky vbrodsky deleted the VB/labeling-service-improve-message-reporting_PLT-1359 branch August 15, 2024 18:36
vbrodsky pushed a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants