Skip to content

[PLT-1357] Vb/fixtures for feature schemas plt 1342 #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Aug 12, 2024

Description

This PR is a follow up in addition to https://labelbox.atlassian.net/browse/PLT-1342 to allow better handling of feature schemas. I have fixed feature schema leaks and flaky tests that were causing original performance issues on stage.

Note we still have many feature schema leaks to fix. I have created https://labelbox.atlassian.net/browse/PLT-1379 to address it post-alignerr

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner August 12, 2024 16:56
@vbrodsky vbrodsky marked this pull request as draft August 12, 2024 16:56
@vbrodsky vbrodsky force-pushed the VB/fixtures-for-feature-schemas_PLT-1342 branch from c57761d to 456aad6 Compare August 12, 2024 17:04
@vbrodsky vbrodsky changed the title Vb/fixtures for feature schemas plt 1342 [PLT-1357] Vb/fixtures for feature schemas plt 1342 Aug 12, 2024
@@ -466,6 +491,24 @@ def prompt_response_ontology(client: Client, rand_gen, prompt_response_features,
print(f"Failed to delete ontology {ontology.uid}: {str(e)}")


@pytest.fixture
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are actual changes. Above is just lint automated changes

@vbrodsky vbrodsky marked this pull request as ready for review August 12, 2024 17:27
@vbrodsky vbrodsky merged commit ca3f880 into develop Aug 12, 2024
19 of 25 checks passed
@vbrodsky vbrodsky deleted the VB/fixtures-for-feature-schemas_PLT-1342 branch August 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants