Skip to content

[PLT-600] Remove hacks and simplified annotation import library #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jul 31, 2024

Description

  • Pulling pieces out of Pydantic v2 converstion. This one is REQUIRED for pydantic v2 because it does not support a previous hack
  • This solution replaces the hack mentioned with a registry system that infers base models. This is still slightly complicated, but I put plenty of comments. It is also less complicated than depending on the order of models for stuff to work or having complicated parts of the code spread among multiple files. (it's contained to this one area)
  • All test run without changing anything inside the test library
  • I think getting base models from dicts is unnecessary, but we need to keep backwards compat

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner July 31, 2024 16:07
@Gabefire Gabefire changed the title [PLT-600] Simplify annotation import library for pydantic v2 [PLT-600] Remove hacks and simplified annotation import library Jul 31, 2024
@vbrodsky
Copy link
Contributor

vbrodsky commented Sep 5, 2024

Migrated diffs to #1738 and closing this PR

@vbrodsky vbrodsky closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants