Skip to content

Improved test where #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Improved test where #1756

wants to merge 4 commits into from

Conversation

Gabefire
Copy link
Collaborator

Description

  • test_where is finicky, and the main problem is due to projects not being ready yet
  • Added a retry loop This is similar logic to our export_v2 helper
  • This won't slow down the test at all just introduce some retries if API is slow since we do not block on on project creation and if multiple projects are created at a time their can be a very slight slow down

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner July 30, 2024 14:47
@Gabefire Gabefire marked this pull request as draft July 30, 2024 14:57
@Gabefire Gabefire force-pushed the gu/fix_tests branch 2 times, most recently from d13be38 to d4eebe5 Compare July 31, 2024 16:33
@Gabefire Gabefire marked this pull request as ready for review July 31, 2024 17:34
@Gabefire Gabefire closed this Jul 31, 2024
@Gabefire Gabefire deleted the gu/fix_tests branch July 31, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gabefire