Skip to content

Set up rye linter in place of formattor #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

Gabefire
Copy link
Collaborator

Description

  • Rye lint uses Ruff under the hood, which uses Rust. This insanely fast linter checks over 800 issues alone, and with MyPy as a type checker, this should catch many more errors then before.
  • Cleaned up quite a few files already. Dup dict keys, bad imports
  • Removed yapf from the workflow since this is formatted and won't do anything else. The formatting it does is merged. I want to switch this out for a global formatter, if possible, using Rye (ruff). Here is a good comparison. I can set this up in the CI sort of how the notebook works pretty easily.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner July 28, 2024 00:14
@Gabefire Gabefire closed this Jul 28, 2024
@Gabefire Gabefire deleted the gu/rye_linter branch July 28, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant