Skip to content

[PLT-1305] Vb/start labeling service plt 1305 #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jul 25, 2024

Stories:
https://labelbox.atlassian.net/browse/PLT-1304
https://labelbox.atlassian.net/browse/PLT-1305

Type of change

A PR to start labeling service and get labeling service status

Example code

    labeling_service = project.request_labeling_service()
    assert labeling_service.status == LabelingServiceStatus.SetUp
    assert labeling_service.project_id == project.uid

    # Check that the labeling service is now available
    labeling_service = project.get_labeling_service()
    assert labeling_service.status == LabelingServiceStatus.SetUp
    assert labeling_service.project_id == project.uid

    labeling_service_status = project.get_labeling_service_status()
    assert labeling_service_status == LabelingServiceStatus.SetUp
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner July 25, 2024 23:16
@vbrodsky vbrodsky force-pushed the VB/start-labeling-service_PLT-1305 branch 2 times, most recently from d49b5c5 to e0eb6d4 Compare July 26, 2024 03:13
@manuaero
Copy link
Collaborator

@vbrodsky wdyt about this method (less imports):

project.start_labeling_service()

@vbrodsky
Copy link
Contributor Author

vbrodsky commented Jul 29, 2024

@vbrodsky wdyt about this method (less imports):

project.start_labeling_service()

Propose project.request_specialized_labelers().

  • to match the UI action
  • I wanted to call the method that sets labeling service to 'requested' start_labeling_service() because to me the meaning of this is that the labeling service is now ready to go from the client point of view

cc @manuaero

@vbrodsky vbrodsky force-pushed the VB/start-labeling-service_PLT-1305 branch from e0eb6d4 to 61b98f2 Compare July 29, 2024 17:04
@vbrodsky vbrodsky force-pushed the VB/start-labeling-service_PLT-1305 branch from 61b98f2 to 6307e8d Compare July 29, 2024 17:08
Returns:
LabelingService: The labeling service for this project.
"""
return LabelingService.get(self.client, self.uid) # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these type ignores?

@vbrodsky vbrodsky merged commit 07fd531 into develop Jul 29, 2024
24 of 27 checks passed
@vbrodsky vbrodsky deleted the VB/start-labeling-service_PLT-1305 branch July 29, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants